Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating several dependencies #1337

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

amitgalitz
Copy link
Member

Description

Updating several dependencies in one PR so its easier to rebase vs a few of the outdated dependabot PRs we have.
I also removed javassist as we don't seem to use it, locally all tests passed without it.

Check List

  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.69%. Comparing base (2ab6dc7) to head (1a9b62d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1337      +/-   ##
============================================
+ Coverage     79.68%   79.69%   +0.01%     
- Complexity     5630     5635       +5     
============================================
  Files           533      533              
  Lines         23410    23410              
  Branches       2323     2323              
============================================
+ Hits          18654    18657       +3     
+ Misses         3651     3647       -4     
- Partials       1105     1106       +1     
Flag Coverage Δ
plugin 79.69% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

@amitgalitz amitgalitz merged commit e612da5 into opensearch-project:main Oct 16, 2024
19 of 20 checks passed
@opensearch-trigger-bot
Copy link

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/anomaly-detection/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/anomaly-detection/backport-2.x
# Create a new branch
git switch --create backport/backport-1337-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e612da5c1c53cc3c7dd73d44b18e7e6f80783563
# Push it to GitHub
git push --set-upstream origin backport/backport-1337-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/anomaly-detection/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1337-to-2.x.

amitgalitz added a commit to amitgalitz/anomaly-detection-1 that referenced this pull request Oct 16, 2024
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
amitgalitz added a commit that referenced this pull request Oct 16, 2024
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport-failed infra Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants